lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Oct 2021 13:50:41 -0300 From: Gabriel Krisman Bertazi <krisman@...labora.com> To: Amir Goldstein <amir73il@...il.com> Cc: Jan Kara <jack@...e.com>, "Darrick J. Wong" <djwong@...nel.org>, Theodore Tso <tytso@....edu>, David Howells <dhowells@...hat.com>, Khazhismel Kumykov <khazhy@...gle.com>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Ext4 <linux-ext4@...r.kernel.org>, Linux API <linux-api@...r.kernel.org>, Matthew Bobrowski <repnop@...gle.com>, kernel@...labora.com Subject: Re: [PATCH v7 20/28] fanotify: Support enqueueing of error events Amir Goldstein <amir73il@...il.com> writes: > On Fri, Oct 15, 2021 at 12:39 AM Gabriel Krisman Bertazi > <krisman@...labora.com> wrote: >> >> Once an error event is triggered, collect the data from the fs error >> report and enqueue it in the notification group, similarly to what is >> done for other events. FAN_FS_ERROR is no longer handled specially, >> since the memory is now handled by a preallocated mempool. >> >> For now, make the event unhashed. A future patch implements merging for >> these kinds of events. >> >> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com> >> --- >> fs/notify/fanotify/fanotify.c | 35 +++++++++++++++++++++++++++++++++++ >> fs/notify/fanotify/fanotify.h | 6 ++++++ >> 2 files changed, 41 insertions(+) >> >> diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c >> index 01d68dfc74aa..9b970359570a 100644 >> --- a/fs/notify/fanotify/fanotify.c >> +++ b/fs/notify/fanotify/fanotify.c >> @@ -574,6 +574,27 @@ static struct fanotify_event *fanotify_alloc_name_event(struct inode *id, >> return &fne->fae; >> } >> >> +static struct fanotify_event *fanotify_alloc_error_event( >> + struct fsnotify_group *group, >> + __kernel_fsid_t *fsid, >> + const void *data, int data_type) >> +{ >> + struct fs_error_report *report = >> + fsnotify_data_error_report(data, data_type); >> + struct fanotify_error_event *fee; >> + >> + if (WARN_ON(!report)) > > WARN_ON_ONCE please. > > Commit message claims to collect the data from the report, > but this commit does nothing with the report?? I moved it out to a separate commit and forgot to update the commit message. Fixed. Thanks! -- Gabriel Krisman Bertazi
Powered by blists - more mailing lists