lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 18 Oct 2021 19:56:13 +0300
From:   Avi Deitcher <>
To:     "Theodore Ts'o" <>
Subject: Re: algorithm for half-md4 used in htree directories

Yes, it definitely was my silly use of sizeof() instead of strlen().
Switch to strlen(), and my test program's output (using little-endian
for each u32) gives the exact same output.

Looks like I owe you that beer (and happy to share it with you) next
time we are in the same place!

On Fri, Oct 15, 2021 at 10:50 PM Theodore Ts'o <> wrote:
> Oh, and taking a quick look at your program, here's at least one of
> the bugs:
> static void calculate(char *name) {
>                       ^^^^^^^^^^
> ...
>     __ext4fs_dirhash(name, sizeof(name), &hinfo);
>                            ^^^^^^^^^^^^
> With apologies to the movie "The Princess Bride"[1]:
>     You fell victim to one of the classic blunders!  The most famous
>     is to never get involved in a land war in Asia, but only slightly
>     less well-known is this: 'taking the size of a C pointer is
>     generally not what you had wanted to do'!  :-)
> [1]
>                                - Ted

Avi Deitcher
Follow me
Read me

Powered by blists - more mailing lists