lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Oct 2021 14:11:02 +0200 From: Jan Kara <jack@...e.cz> To: Gabriel Krisman Bertazi <krisman@...labora.com> Cc: amir73il@...il.com, jack@...e.com, djwong@...nel.org, tytso@....edu, david@...morbit.com, dhowells@...hat.com, khazhy@...gle.com, linux-fsdevel@...r.kernel.org, linux-api@...r.kernel.org, linux-ext4@...r.kernel.org, kernel@...labora.com, Jan Kara <jack@...e.cz> Subject: Re: [PATCH v9 27/31] fanotify: Emit generic error info for error event On Mon 25-10-21 16:27:42, Gabriel Krisman Bertazi wrote: > The error info is a record sent to users on FAN_FS_ERROR events > documenting the type of error. It also carries an error count, > documenting how many errors were observed since the last reporting. > > Reviewed-by: Amir Goldstein <amir73il@...il.com> > Reviewed-by: Jan Kara <jack@...e.cz> > Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com> ... > @@ -530,6 +557,14 @@ static int copy_info_records_to_user(struct fanotify_event *event, > total_bytes += ret; > } > > + if (fanotify_is_error_event(event->mask)) { > + ret = copy_error_info_to_user(event, buf, count); > + if (ret < 0) > + return ret; > + buf += ret; > + count -= ret; > + } > + > return total_bytes; > } This is currently harmless but we should add total_bytes += ret; here as well. Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists