linux-ext4 - Re: [PATCH v3 08/13] ext4: get rid of super block and sbi from handle_mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Oct 2021 09:32:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Lukas Czerner <lczerner@...hat.com>, linux-ext4@...r.kernel.org,
        tytso@....edu
Cc:     kbuild-all@...ts.01.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3 08/13] ext4: get rid of super block and sbi from
 handle_mount_ops()

Hi Lukas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on d9abdee5fd5abffd0e763e52fbfa3116de167822]

url:    https://github.com/0day-ci/linux/commits/Lukas-Czerner/ext4-new-mount-API-conversion/20211021-194735
base:   d9abdee5fd5abffd0e763e52fbfa3116de167822
config: arc-buildonly-randconfig-r003-20211026 (attached as .config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/7a72c1e0e5cd5dfab89d8122ebfb47a73e2efc27
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lukas-Czerner/ext4-new-mount-API-conversion/20211021-194735
        git checkout 7a72c1e0e5cd5dfab89d8122ebfb47a73e2efc27
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/ext4/super.c: In function 'ext4_validate_options':
>> fs/ext4/super.c:2947:33: error: unused variable 'ctx' [-Werror=unused-variable]
    2947 |         struct ext4_fs_context *ctx = fc->fs_private;
         |                                 ^~~
   fs/ext4/super.c: In function 'ext4_remount':
   fs/ext4/super.c:6210:13: error: variable 'enable_quota' set but not used [-Werror=unused-but-set-variable]
    6210 |         int enable_quota = 0;
         |             ^~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/ctx +2947 fs/ext4/super.c

  2943	
  2944	
  2945	static int ext4_validate_options(struct fs_context *fc)
  2946	{
> 2947		struct ext4_fs_context *ctx = fc->fs_private;
  2948	#ifdef CONFIG_QUOTA
  2949		char *usr_qf_name, *grp_qf_name;
  2950	
  2951		usr_qf_name = ctx->s_qf_names[USRQUOTA];
  2952		grp_qf_name = ctx->s_qf_names[GRPQUOTA];
  2953	
  2954		if (usr_qf_name || grp_qf_name) {
  2955			if (ctx_test_mount_opt(ctx, EXT4_MOUNT_USRQUOTA) && usr_qf_name)
  2956				ctx_clear_mount_opt(ctx, EXT4_MOUNT_USRQUOTA);
  2957	
  2958			if (ctx_test_mount_opt(ctx, EXT4_MOUNT_GRPQUOTA) && grp_qf_name)
  2959				ctx_clear_mount_opt(ctx, EXT4_MOUNT_GRPQUOTA);
  2960	
  2961			if (ctx_test_mount_opt(ctx, EXT4_MOUNT_USRQUOTA) ||
  2962			    ctx_test_mount_opt(ctx, EXT4_MOUNT_GRPQUOTA)) {
  2963				ext4_msg(NULL, KERN_ERR, "old and new quota "
  2964					 "format mixing");
  2965				return -EINVAL;
  2966			}
  2967		}
  2968	#endif
  2969		return 1;
  2970	}
  2971	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (27925 bytes)