lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 27 Oct 2021 12:57:32 +0300
From:   Amir Goldstein <amir73il@...il.com>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     LTP List <ltp@...ts.linux.it>, Jan Kara <jack@...e.com>,
        Khazhismel Kumykov <khazhy@...gle.com>, kernel@...labora.com,
        Ext4 <linux-ext4@...r.kernel.org>,
        Matthew Bobrowski <repnop@...gle.com>
Subject: Re: [PATCH v2 09/10] syscalls/fanotify20: Test file event with broken inode

On Tue, Oct 26, 2021 at 9:44 PM Gabriel Krisman Bertazi
<krisman@...labora.com> wrote:
>
> This test corrupts an inode entry with an invalid mode through debugfs
> and then tries to access it.  This should result in a ext4 error, which
> we monitor through the fanotify group.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>

Reviewed-by: Amir Goldstein <amir73il@...il.com>

> ---
>  .../kernel/syscalls/fanotify/fanotify20.c     | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify20.c b/testcases/kernel/syscalls/fanotify/fanotify20.c
> index 5c5ee3c6fb74..7bcddcaa98cb 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify20.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify20.c
> @@ -38,6 +38,10 @@
>  #define        FILEID_INVALID          0xff
>  #endif
>
> +#ifndef EFSCORRUPTED
> +#define EFSCORRUPTED    EUCLEAN         /* Filesystem is corrupted */
> +#endif
> +
>  #define BUF_SIZE 256
>  static char event_buf[BUF_SIZE];
>  int fd_notify;
> @@ -63,6 +67,17 @@ static void trigger_fs_abort(void)
>                    MS_REMOUNT|MS_RDONLY, "abort");
>  }
>
> +static void tcase2_trigger_lookup(void)
> +{
> +       int ret;
> +
> +       /* SAFE_OPEN cannot be used here because we expect it to fail. */
> +       ret = open(MOUNT_PATH"/"BAD_DIR, O_RDONLY, 0);
> +       if (ret != -1 && errno != EUCLEAN)
> +               tst_res(TFAIL, "Unexpected lookup result(%d) of %s (%d!=%d)",
> +                       ret, BAD_DIR, errno, EUCLEAN);
> +}
> +
>  static struct test_case {
>         char *name;
>         int error;
> @@ -77,6 +92,13 @@ static struct test_case {
>                 .error = ESHUTDOWN,
>                 .fid = &null_fid,
>         },
> +       {
> +               .name = "Lookup of inode with invalid mode",
> +               .trigger_error = &tcase2_trigger_lookup,
> +               .error_count = 1,
> +               .error = EFSCORRUPTED,
> +               .fid = &bad_file_fid,
> +       },
>  };
>
>  int check_error_event_info_fid(struct fanotify_event_info_fid *fid,
> --
> 2.33.0
>

Powered by blists - more mailing lists