lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Oct 2021 13:19:36 +0300 From: Amir Goldstein <amir73il@...il.com> To: Gabriel Krisman Bertazi <krisman@...labora.com> Cc: LTP List <ltp@...ts.linux.it>, Jan Kara <jack@...e.com>, Khazhismel Kumykov <khazhy@...gle.com>, kernel@...labora.com, Ext4 <linux-ext4@...r.kernel.org>, Matthew Bobrowski <repnop@...gle.com> Subject: Re: [PATCH v2 04/10] syscalls/fanotify20: Validate the generic error info On Wed, Oct 27, 2021 at 9:43 AM Amir Goldstein <amir73il@...il.com> wrote: > > On Tue, Oct 26, 2021 at 9:43 PM Gabriel Krisman Bertazi > <krisman@...labora.com> wrote: > > > > Implement some validation for the generic error info record emitted by > > the kernel. The error number is fs-specific but, well, we only support > > ext4 for now anyway. > > > > Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com> > > > > After fixing and testing configure.ac you may add: > > Reviewed-by: Amir Goldstein <amir73il@...il.com> > > > --- > > Changes since v1: > > - Move defines to header file. > > --- > > testcases/kernel/syscalls/fanotify/fanotify.h | 32 +++++++++++++++++ > > .../kernel/syscalls/fanotify/fanotify20.c | 35 ++++++++++++++++++- > > 2 files changed, 66 insertions(+), 1 deletion(-) > > > > diff --git a/testcases/kernel/syscalls/fanotify/fanotify.h b/testcases/kernel/syscalls/fanotify/fanotify.h > > index 8828b53532a2..58e30aaf00bc 100644 > > --- a/testcases/kernel/syscalls/fanotify/fanotify.h > > +++ b/testcases/kernel/syscalls/fanotify/fanotify.h > > @@ -167,6 +167,9 @@ typedef struct { > > #ifndef FAN_EVENT_INFO_TYPE_DFID > > #define FAN_EVENT_INFO_TYPE_DFID 3 > > #endif > > +#ifndef FAN_EVENT_INFO_TYPE_ERROR > > +#define FAN_EVENT_INFO_TYPE_ERROR 5 > > +#endif > > > > #ifndef HAVE_STRUCT_FANOTIFY_EVENT_INFO_HEADER > > struct fanotify_event_info_header { > > @@ -184,6 +187,14 @@ struct fanotify_event_info_fid { > > }; > > #endif /* HAVE_STRUCT_FANOTIFY_EVENT_INFO_FID */ > > > > +#ifndef HAVE_STRUCT_FANOTIFY_EVENT_INFO_ERROR > > +struct fanotify_event_info_error { > > + struct fanotify_event_info_header hdr; > > + __s32 error; > > + __u32 error_count; > > +}; > > +#endif /* HAVE_STRUCT_FANOTIFY_EVENT_INFO_ERROR */ > > Need to add in configure.ac: > > AC_CHECK_TYPES([struct fanotify_event_info_error, struct > fanotify_event_info_header],,,[#include <sys/fanotify.h>]) > > (not tested) According to Matthew's pidfd patches the syntax should be: AC_CHECK_TYPES([struct fanotify_event_info_fid, struct fanotify_event_info_header, struct fanotify_event_info_pidfd, struct fanotify_event_info_error],,,[#include <sys/fanotify.h>]) Thanks, Amir.
Powered by blists - more mailing lists