linux-ext4 - Re: [PATCH] ext4: Fix error code saved on super block during file system abort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu,  4 Nov 2021 10:48:17 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        kernel@...labora.com, adilger.kernel@...ger.ca
Subject: Re: [PATCH] ext4: Fix error code saved on super block during file system abort

On Tue, 26 Oct 2021 14:33:02 -0300, Gabriel Krisman Bertazi wrote:
> ext4_abort will eventually call ext4_errno_to_code, which translates the
> errno to an EXT4_ERR specific error.  This means that ext4_abort expects
> an errno.  By using EXT4_ERR_ here, it gets misinterpreted (as an errno),
> and ends up saving EXT4_ERR_EBUSY on the superblock during an abort,
> which makes no sense.
> 
> ESHUTDOWN will get properly translated to EXT4_ERR_SHUTDOWN, so use that
> instead.
> 
> [...]

Applied, thanks!

[1/1] ext4: Fix error code saved on super block during file system abort
      commit: 124e7c61deb27d758df5ec0521c36cf08d417f7a

Best regards,
-- 
Theodore Ts'o <tytso@....edu>