lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu,  4 Nov 2021 06:34:06 +0000
To:     Theodore Ts'o <>
Cc:     Andreas Dilger <>,,,
        luo penghao <>,
        Zeal Robot <>
Subject: [PATCH v2] ext4: Remove redundant statement

From: luo penghao <>

The local variable assignment at the end of the function is meaningless.

The clang_analyzer complains as follows:

fs/ext4/fast_commit.c:779:2 warning:

Value stored to 'dst' is never read

change in v2:

Repair the sending email box

Reported-by: Zeal Robot <>
Signed-off-by: luo penghao <>
 fs/ext4/fast_commit.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 782d05a..9e5bfa0 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -797,7 +797,6 @@ static  bool ext4_fc_add_dentry_tlv(struct super_block *sb, u16 tag,
 	ext4_fc_memcpy(sb, dst, &fcd, sizeof(fcd), crc);
 	dst += sizeof(fcd);
 	ext4_fc_memcpy(sb, dst, dname, dlen, crc);
-	dst += dlen;
 	return true;

Powered by blists - more mailing lists