lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Nov 2021 14:33:26 -0800 From: "Darrick J. Wong" <djwong@...nel.org> To: Christoph Hellwig <hch@....de> Cc: Dan Williams <dan.j.williams@...el.com>, Mike Snitzer <snitzer@...hat.com>, Ira Weiny <ira.weiny@...el.com>, dm-devel@...hat.com, linux-xfs@...r.kernel.org, nvdimm@...ts.linux.dev, linux-s390@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org, virtualization@...ts.linux-foundation.org Subject: Re: [PATCH 12/29] fsdax: remove a pointless __force cast in copy_cow_page_dax On Tue, Nov 09, 2021 at 09:32:52AM +0100, Christoph Hellwig wrote: > Despite its name copy_user_page expected kernel addresses, which is what > we already have. > > Signed-off-by: Christoph Hellwig <hch@....de> Looks ok, Reviewed-by: Darrick J. Wong <djwong@...nel.org> --D > --- > fs/dax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 4e3e5a283a916..73bd1439d8089 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -728,7 +728,7 @@ static int copy_cow_page_dax(struct block_device *bdev, struct dax_device *dax_d > return rc; > } > vto = kmap_atomic(to); > - copy_user_page(vto, (void __force *)kaddr, vaddr, to); > + copy_user_page(vto, kaddr, vaddr, to); > kunmap_atomic(vto); > dax_read_unlock(id); > return 0; > -- > 2.30.2 >
Powered by blists - more mailing lists