lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Nov 2021 07:37:35 +0100 From: Christoph Hellwig <hch@....de> To: "Darrick J. Wong" <djwong@...nel.org> Cc: Christoph Hellwig <hch@....de>, Dan Williams <dan.j.williams@...el.com>, Mike Snitzer <snitzer@...hat.com>, Ira Weiny <ira.weiny@...el.com>, dm-devel@...hat.com, linux-xfs@...r.kernel.org, nvdimm@...ts.linux.dev, linux-s390@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org, virtualization@...ts.linux-foundation.org Subject: Re: [PATCH 08/29] dax: remove dax_capable On Tue, Nov 23, 2021 at 02:31:23PM -0800, Darrick J. Wong wrote: > > - struct super_block *sb = mp->m_super; > > - > > - if (!xfs_buftarg_is_dax(sb, mp->m_ddev_targp) && > > - (!mp->m_rtdev_targp || !xfs_buftarg_is_dax(sb, mp->m_rtdev_targp))) { > > + if (!mp->m_ddev_targp->bt_daxdev && > > + (!mp->m_rtdev_targp || !mp->m_rtdev_targp->bt_daxdev)) { > > Nit: This ^ paren should be indented one more column because it's a > sub-clause of the if() test. Done. > Nit: xfs_alert() already adds a newline to the end of the format string. Already done in the current tree.
Powered by blists - more mailing lists