lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Nov 2021 18:52:13 -0800 From: Dan Williams <dan.j.williams@...el.com> To: Christoph Hellwig <hch@....de> Cc: Mike Snitzer <snitzer@...hat.com>, Ira Weiny <ira.weiny@...el.com>, device-mapper development <dm-devel@...hat.com>, linux-xfs <linux-xfs@...r.kernel.org>, Linux NVDIMM <nvdimm@...ts.linux.dev>, linux-s390 <linux-s390@...r.kernel.org>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, linux-erofs@...ts.ozlabs.org, linux-ext4 <linux-ext4@...r.kernel.org>, virtualization@...ts.linux-foundation.org Subject: Re: [PATCH 24/29] xfs: use xfs_direct_write_iomap_ops for DAX zeroing On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig <hch@....de> wrote: > > While the buffered write iomap ops do work due to the fact that zeroing > never allocates blocks, the DAX zeroing should use the direct ops just > like actual DAX I/O. > I always wondered about this, change looks good to me. Reviewed-by: Dan Williams <dan.j.williams@...el.com> > Signed-off-by: Christoph Hellwig <hch@....de> > --- > fs/xfs/xfs_iomap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c > index 8cef3b68cba78..704292c6ce0c7 100644 > --- a/fs/xfs/xfs_iomap.c > +++ b/fs/xfs/xfs_iomap.c > @@ -1324,7 +1324,7 @@ xfs_zero_range( > > if (IS_DAX(inode)) > return dax_zero_range(inode, pos, len, did_zero, > - &xfs_buffered_write_iomap_ops); > + &xfs_direct_write_iomap_ops); > return iomap_zero_range(inode, pos, len, did_zero, > &xfs_buffered_write_iomap_ops); > } > @@ -1339,7 +1339,7 @@ xfs_truncate_page( > > if (IS_DAX(inode)) > return dax_truncate_page(inode, pos, did_zero, > - &xfs_buffered_write_iomap_ops); > + &xfs_direct_write_iomap_ops); > return iomap_truncate_page(inode, pos, did_zero, > &xfs_buffered_write_iomap_ops); > } > -- > 2.30.2 >
Powered by blists - more mailing lists