linux-ext4 - [bug report] ext4: fast commit recovery path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Nov 2021 12:40:06 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     harshadshirwadkar@...il.com
Cc:     linux-ext4@...r.kernel.org
Subject: [bug report] ext4: fast commit recovery path

Hello Harshad Shirwadkar,

The patch 8016e29f4362: "ext4: fast commit recovery path" from Oct
15, 2020, leads to the following Smatch static checker warnings:

	fs/ext4/inode.c:4533 __ext4_get_inode_loc_noinmem()
	error: uninitialized symbol 'err_blk'.

	fs/ext4/inode.c:4548 ext4_get_inode_loc()
	error: uninitialized symbol 'err_blk'.

fs/ext4/inode.c
    4523 static int __ext4_get_inode_loc_noinmem(struct inode *inode,
    4524                                         struct ext4_iloc *iloc)
    4525 {
    4526         ext4_fsblk_t err_blk;
    4527         int ret;
    4528 
    4529         ret = __ext4_get_inode_loc(inode->i_sb, inode->i_ino, NULL, iloc,
    4530                                         &err_blk);
    4531 
    4532         if (ret == -EIO)
--> 4533                 ext4_error_inode_block(inode, err_blk, EIO,

Only the last return -EIO sets err_blk.  The first return -EIO leaves it
uninitialized.

    4534                                         "unable to read itable block");
    4535 
    4536         return ret;
    4537 }

regards,
dan carpenter