linux-ext4 - Re: [PATCH] xfstests-bld: add ext4/044 to adv.exclude

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yblp57PzXr0MVfdy@mit.edu>
Date:   Tue, 14 Dec 2021 23:07:03 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Eric Whitney <enwlinux@...il.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] xfstests-bld: add ext4/044 to adv.exclude

On Tue, Dec 14, 2021 at 03:56:17PM -0500, Eric Whitney wrote:
> Test ext4/044 fails when run in the adv test case because it explicitly
> attempts to mount a test file system created with the inline_data
> feature as ext3.  The inline_data feature and ext3 are incompatible,
> and the mount attempt fails.
> 
> This test did not fail in earlier xfstests-bld versions because the
> features included in adv were different.  In particular, the 64bit
> feature was applied, and this had an unfortunate side effect.
> Because the 64bit feature requires extents, and because the test
> attempts to create an ext3 file system, the initial attempt actually
> failed.  This was hidden by behavior in the xfstest function
> _scratch_do_mkfs, which then attempted to create the file system without
> the supplied "extra" mkfs options (those supplied for the adv test case).
> So, the test file system was not created with inline_data, the explicit
> attempt to mount the test file system as ext3 succeeded, and the test
> passed without testing anything particular to the adv test case.
> 
> Signed-off-by: Eric Whitney <enwlinux@...il.com>

Thanks, applied.

					- Ted