linux-ext4 - Re: [PATCH] ext4: fix a copy and paste typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Dec 2021 13:10:33 +0100
From:   Lukas Czerner <lczerner@...hat.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Carlos Maiolino <cmaiolino@...hat.com>,
        linux-ext4@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ext4: fix a copy and paste typo

On Wed, Dec 15, 2021 at 02:43:09PM +0300, Dan Carpenter wrote:
> This was obviously supposed to be an ext4 struct, not xfs.  GCC
> doesn't care either way so it doesn't affect the build or runtime.

Wow, what a mistake. Nice catch, thanks!

Reviewed-by: Lukas Czerner <lczerner@...hat.com>

> 
> Fixes: cebe85d570cf ("ext4: switch to the new mount api")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
>  fs/ext4/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 5ec5a1c3b364..da40fb468d7f 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2077,7 +2077,7 @@ static void ext4_fc_free(struct fs_context *fc)
>  
>  int ext4_init_fs_context(struct fs_context *fc)
>  {
> -	struct xfs_fs_context	*ctx;
> +	struct ext4_fs_context *ctx;
>  
>  	ctx = kzalloc(sizeof(struct ext4_fs_context), GFP_KERNEL);
>  	if (!ctx)
> -- 
> 2.20.1
>