linux-ext4 - Re: [PATCH 0/2] ext4: fast commit crash consistency issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD+ocbxLHJ2KK44gT0u7zei--UBJ1CRRKyra8Hhx1CvtCcOpQA@mail.gmail.com>
Date:   Thu, 23 Dec 2021 12:13:22 -0800
From:   harshad shirwadkar <harshadshirwadkar@...il.com>
To:     Xin Yin <yinxin.x@...edance.com>
Cc:     "Theodore Y. Ts'o" <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] ext4: fast commit crash consistency issues

Thanks for the patches, these are good finds.

Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@...il.com>

On Wed, Dec 22, 2021 at 7:24 PM Xin Yin <yinxin.x@...edance.com> wrote:
>
> This patch sets fix 2 crash-consistency issues of fast commit.
> First patch change to use ext4_ext_remove_space instead of
> ext4_punch_hole during replay delete range procedure. This
> avoid replay procedure being affeced by incorrect inode->i_size.
> Second patch correct the trank range logic for ftruncte.
>
> After testing this patch sets with xfstests-bld, in the "log" and
> "quick" group with config "fast_commit" is selected. No regressions
> was found.
>
> Signed-off-by: Xin Yin <yinxin.x@...edance.com>
>
> Xin Yin (2):
>   ext4: use ext4_ext_remove_space() for fast commit replay delete range
>   ext4: fast commit may miss tracking unwritten range during ftruncate
>
>  fs/ext4/fast_commit.c | 13 ++++++++-----
>  fs/ext4/inode.c       |  3 +--
>  2 files changed, 9 insertions(+), 7 deletions(-)
>
> --
> 2.20.1
>