linux-ext4 - Re: [PATCH 1/2] ext4: Change s_last_trim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Jan 2022 22:52:30 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org, adilger@...ger.ca
Subject: Re: [PATCH 1/2] ext4: Change s_last_trim_minblks type to unsigned
 long

On Wed, Nov 03, 2021 at 03:51:21PM +0100, Lukas Czerner wrote:
> There is no good reason for the s_last_trim_minblks to be atomic. There is
> no data integrity needed and there is no real danger in setting and
> reading it in a racy manner. Change it to be unsigned long, the same type
> as s_clusters_per_group which is the maximum that's allowed.
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> Suggested-by: Andreas Dilger <adilger@...ger.ca>
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied.

					- Ted