lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Jan 2022 14:06:56 +0530 From: Ritesh Harjani <riteshh@...ux.ibm.com> To: linux-ext4@...r.kernel.org Cc: xu.xin16@....com.cn, Ritesh Harjani <riteshh@...ux.ibm.com> Subject: [PATCH] ext4: Simplify !page_bufs logic with simple BUG_ON() Simplify !page_bufs logic with simple BUG_ON(). Signed-off-by: Ritesh Harjani <riteshh@...ux.ibm.com> --- Noticed a bug_on() related patch while reviewing, hence felt, this below trivial change could be included along with it. fs/ext4/inode.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index bfd3545f1e5d..5656b4a9007b 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1879,10 +1879,7 @@ static int __ext4_journalled_writepage(struct page *page, goto out; } else { page_bufs = page_buffers(page); - if (!page_bufs) { - BUG(); - goto out; - } + BUG_ON(!page_bufs); ext4_walk_page_buffers(handle, inode, page_bufs, 0, len, NULL, bget_one); } -- 2.31.1
Powered by blists - more mailing lists