linux-ext4 - Re: [PATCH] ext4: Simplify !page_bufs logic with simple BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdZyFnRH90FfeJLw@mit.edu>
Date:   Wed, 5 Jan 2022 23:37:42 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>
Cc:     linux-ext4@...r.kernel.org, xu.xin16@....com.cn
Subject: Re: [PATCH] ext4: Simplify !page_bufs logic with simple BUG_ON()

On Wed, Jan 05, 2022 at 02:06:56PM +0530, Ritesh Harjani wrote:
> Simplify !page_bufs logic with simple BUG_ON().
> 
> @@ -1879,10 +1879,7 @@ static int __ext4_journalled_writepage(struct page *page,
>  			goto out;
>  	} else {
>  		page_bufs = page_buffers(page);
> -		if (!page_bufs) {
> -			BUG();
> -			goto out;
> -		}
> +		BUG_ON(!page_bufs);
>  		ext4_walk_page_buffers(handle, inode, page_bufs, 0, len,
>  				       NULL, bget_one);
>  	}

This code was removed by:

    https://lore.kernel.org/r/20211225090937.712867-1-yi.zhang@huawei.com

... so this patch is no longer needed.

						- Ted