lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Jan 2022 10:28:37 +0200 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Christoph Hellwig <hch@....de> Cc: Gabriel Krisman Bertazi <krisman@...labora.com>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, Ext4 Developers List <linux-ext4@...r.kernel.org>, Linux F2FS Dev Mailing List <linux-f2fs-devel@...ts.sourceforge.net> Subject: Re: [PATCH] unicode: clean up the Kconfig symbol confusion On Tue, Jan 18, 2022 at 8:56 AM Christoph Hellwig <hch@....de> wrote: > > Note that a lot of the IS_ENALBED() checks could be turned from cpp > statements into normal ifs, but this change is intended to be fairly > mechanic, so that should be cleaned up later. Yeah, that patch looks uglier than what I would have hoped for, but a number of the conversions really look like they then would get a lot cleaner if the IS_ENABLED() was part of the code flow, rather than have those ugly (and now arguably even uglier) #ifdef's inside code. And I think the mechanical conversion is the right thing to do, with any cleanup being separate. I'll look at this again when I have all my pulls done. Linus
Powered by blists - more mailing lists