lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Jan 2022 10:43:37 +0530 From: Ritesh Harjani <riteshh@...ux.ibm.com> To: Xin Yin <yinxin.x@...edance.com> Cc: harshadshirwadkar@...il.com, tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com> Subject: Re: [PATCH] ext4: fix incorrect type issue during replay_del_range On 22/01/26 02:31PM, Xin Yin wrote: > should not use fast commit log data directly, add le32_to_cpu(). > > Reported-by: kernel test robot <lkp@...el.com> > Fixes: 0b5b5a62b945 ("ext4: use ext4_ext_remove_space() for fast commit replay delete range") > Signed-off-by: Xin Yin <yinxin.x@...edance.com> Yes, a required change indeed. Since the patch marked as fixes was cc'd to stable, so this might be requird as well. Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com> > --- > fs/ext4/fast_commit.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c > index ccd2b216d6ba..488347b4c8b0 100644 > --- a/fs/ext4/fast_commit.c > +++ b/fs/ext4/fast_commit.c > @@ -1798,8 +1798,9 @@ ext4_fc_replay_del_range(struct super_block *sb, struct ext4_fc_tl *tl, > } > > down_write(&EXT4_I(inode)->i_data_sem); > - ret = ext4_ext_remove_space(inode, lrange.fc_lblk, > - lrange.fc_lblk + lrange.fc_len - 1); > + ret = ext4_ext_remove_space(inode, le32_to_cpu(lrange.fc_lblk), > + le32_to_cpu(lrange.fc_lblk) + > + le32_to_cpu(lrange.fc_len) - 1); > up_write(&EXT4_I(inode)->i_data_sem); > if (ret) { > iput(inode); > -- > 2.25.1 >
Powered by blists - more mailing lists