linux-ext4 - Re: [PATCH][next] ext2: remove unused pointer bdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220207144612.zdczs7wxzbuk3ydr@quack3.lan>
Date:   Mon, 7 Feb 2022 15:46:12 +0100
From:   Jan Kara <jack@...e.cz>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Jan Kara <jack@...e.com>, Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        NeilBrown <neilb@...e.de>, linux-ext4@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ext2: remove unused pointer bdi

On Mon 07-02-22 13:40:39, Colin Ian King wrote:
> The call to bdi_congested has been removed and so the bdi pointer
> is no longer required. Remove it.
> 
> Fixes: 9bbab3a63d49 ("mm/fs: remove bdi_congested() and wb_congested() and related functions")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

I guess this change is in mm tree? So probably it is best if Andrew picks
it up.

								Honza

> ---
>  fs/ext2/ialloc.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index d632764da240..998dd2ac8008 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -170,9 +170,6 @@ static void ext2_preread_inode(struct inode *inode)
>  	unsigned long offset;
>  	unsigned long block;
>  	struct ext2_group_desc * gdp;
> -	struct backing_dev_info *bdi;
> -
> -	bdi = inode_to_bdi(inode);
>  
>  	block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
>  	gdp = ext2_get_group_desc(inode->i_sb, block_group, NULL);
> -- 
> 2.34.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR