linux-ext4 - Re: [RFC 7/9] ext4: Fix remaining two trace events to use same printk convention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 Feb 2022 10:45:09 +0100
From:   Jan Kara <jack@...e.cz>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>
Cc:     linux-ext4@...r.kernel.org,
        Harshad Shirwadkar <harshadshirwadkar@...il.com>,
        Theodore Ts'o <tytso@....edu>, Jan Kara <jack@...e.cz>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 7/9] ext4: Fix remaining two trace events to use same
 printk convention

On Wed 23-02-22 02:04:15, Ritesh Harjani wrote:
> All ext4 & jbd2 trace events starts with "dev Major:Minor".
> While we are still improving/adding the ftrace events for FC,
> let's fix last two remaining trace events to follow the same
> convention.
> 
> Signed-off-by: Ritesh Harjani <riteshh@...ux.ibm.com>

OK. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  include/trace/events/ext4.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/trace/events/ext4.h b/include/trace/events/ext4.h
> index 6e66cb7ce624..233dbffa5ceb 100644
> --- a/include/trace/events/ext4.h
> +++ b/include/trace/events/ext4.h
> @@ -2653,7 +2653,7 @@ TRACE_EVENT(ext4_fc_replay_scan,
>  		__entry->off = off;
>  	),
>  
> -	TP_printk("FC scan pass on dev %d,%d: error %d, off %d",
> +	TP_printk("dev %d,%d error %d, off %d",
>  		  MAJOR(__entry->dev), MINOR(__entry->dev),
>  		  __entry->error, __entry->off)
>  );
> @@ -2679,7 +2679,7 @@ TRACE_EVENT(ext4_fc_replay,
>  		__entry->priv2 = priv2;
>  	),
>  
> -	TP_printk("FC Replay %d,%d: tag %d, ino %d, data1 %d, data2 %d",
> +	TP_printk("dev %d,%d: tag %d, ino %d, data1 %d, data2 %d",
>  		  MAJOR(__entry->dev), MINOR(__entry->dev),
>  		  __entry->tag, __entry->ino, __entry->priv1, __entry->priv2)
>  );
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR