lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Apr 2022 09:04:46 +0200 From: Alan.Robinson@...itsu.com (Alan Robinson) To: Christoph Hellwig <hch@....de> Cc: Jens Axboe <axboe@...nel.dk>, "jfs-discussion@...ts.sourceforge.net" <jfs-discussion@...ts.sourceforge.net>, "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>, "virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, "dm-devel@...hat.com" <dm-devel@...hat.com>, "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>, "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>, "drbd-dev@...ts.linbit.com" <drbd-dev@...ts.linbit.com>, "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>, "linux-nilfs@...r.kernel.org" <linux-nilfs@...r.kernel.org>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "cluster-devel@...hat.com" <cluster-devel@...hat.com>, "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>, "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>, "linux-um@...ts.infradead.org" <linux-um@...ts.infradead.org>, "nbd@...er.debian.org" <nbd@...er.debian.org>, "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>, "linux-bcache@...r.kernel.org" <linux-bcache@...r.kernel.org>, "ceph-devel@...r.kernel.org" <ceph-devel@...r.kernel.org>, "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, "linux-f2fs-devel@...ts.sourceforge.net" <linux-f2fs-devel@...ts.sourceforge.net>, "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>, "ocfs2-devel@....oracle.com" <ocfs2-devel@....oracle.com>, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>, "ntfs3@...ts.linux.dev" <ntfs3@...ts.linux.dev>, "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org> Subject: Re: [PATCH 15/27] block: use bdev_alignment_offset in part_alignment_offset_show Hi Christoph, On Wed, Apr 06, 2022 at 06:05:04AM +0000, Christoph Hellwig wrote: > From: Christoph Hellwig <hch@....de> > Subject: [PATCH 15/27] block: use bdev_alignment_offset in > part_alignment_offset_show > > Replace the open coded offset calculation with the proper helper. > This is an ABI change in that the -1 for a misaligned partition is > properly propagated, which can be considered a bug fix and maches s/maches/matches/ > what is done on the whole device. > > Signed-off-by: Christoph Hellwig <hch@....de> > --- > block/partitions/core.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/block/partitions/core.c b/block/partitions/core.c > index 2ef8dfa1e5c85..240b3fff521e4 100644 > --- a/block/partitions/core.c > +++ b/block/partitions/core.c > @@ -200,11 +200,7 @@ static ssize_t part_ro_show(struct device *dev, > static ssize_t part_alignment_offset_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct block_device *bdev = dev_to_bdev(dev); > - > - return sprintf(buf, "%u\n", > - queue_limit_alignment_offset(&bdev_get_queue(bdev)->limits, > - bdev->bd_start_sect)); > + return sprintf(buf, "%u\n", bdev_alignment_offset(dev_to_bdev(dev))); Should this now be %d instead of %u, there are one or two examples of both in the rest of the patch series. Alan
Powered by blists - more mailing lists