linux-ext4 - Re: [Ocfs2-devel] [PATCH 21/27] block: move {bdev, queue_limit}_discard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1k0c1h8w3.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 06 Apr 2022 23:27:40 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Christoph Hellwig via Ocfs2-devel <ocfs2-devel@....oracle.com>
Cc:     Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
        jfs-discussion@...ts.sourceforge.net,
        linux-nvme@...ts.infradead.org,
        virtualization@...ts.linux-foundation.org, linux-mm@...ck.org,
        dm-devel@...hat.com, target-devel@...r.kernel.org,
        linux-mtd@...ts.infradead.org, drbd-dev@...ts.linbit.com,
        linux-s390@...r.kernel.org, linux-nilfs@...r.kernel.org,
        linux-scsi@...r.kernel.org, cluster-devel@...hat.com,
        xen-devel@...ts.xenproject.org, linux-ext4@...r.kernel.org,
        linux-um@...ts.infradead.org, nbd@...er.debian.org,
        linux-block@...r.kernel.org, linux-bcache@...r.kernel.org,
        ceph-devel@...r.kernel.org, linux-raid@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        ntfs3@...ts.linux.dev, linux-btrfs@...r.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 21/27] block: move {bdev,
 queue_limit}_discard_alignment out of line


Christoph,

> No need to inline these fairly larger helpers.  Also fix the return
> value to be unsigned, just like the field in struct queue_limits.

I believe the original reason for the signed int here was to be able to
express -1 for sysfs. I am not sure why I didn't just use the misaligned
flag.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering