lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220411032337.2517465-1-lv.ruyi@zte.com.cn> Date: Mon, 11 Apr 2022 03:23:37 +0000 From: cgel.zte@...il.com To: tytso@....edu, adilger.kernel@...ger.ca Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, Lv Ruyi <lv.ruyi@....com.cn>, Zeal Robot <zealci@....com.cn> Subject: [PATCH v2] ext4: remove unnecessary conditional From: Lv Ruyi <lv.ruyi@....com.cn> iput() has already handled null and non-null parameter, so it is no need to use if(). Reported-by: Zeal Robot <zealci@....com.cn> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn> --- v2: change subject from "remove redundant judgment" to "remove unnecessary conditional" --- fs/ext4/fast_commit.c | 3 +-- fs/ext4/namei.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index 3d72565ec6e8..e85d351a1a31 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -1659,8 +1659,7 @@ static int ext4_fc_replay_create(struct super_block *sb, struct ext4_fc_tl *tl, set_nlink(inode, 1); ext4_mark_inode_dirty(NULL, inode); out: - if (inode) - iput(inode); + iput(inode); return ret; } diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c index e37da8d5cd0c..2fd3b24a21cd 100644 --- a/fs/ext4/namei.c +++ b/fs/ext4/namei.c @@ -3363,8 +3363,7 @@ static int ext4_symlink(struct user_namespace *mnt_userns, struct inode *dir, err = ext4_add_nondir(handle, dentry, &inode); if (handle) ext4_journal_stop(handle); - if (inode) - iput(inode); + iput(inode); goto out_free_encrypted_link; err_drop_inode: -- 2.25.1
Powered by blists - more mailing lists