linux-ext4 - Re: [PATCH] ext4, doc: Fix incorrect h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ee1x2yn3.fsf@meer.lwn.net>
Date:   Sat, 16 Apr 2022 02:58:08 -0600
From:   Jonathan Corbet <corbet@....net>
To:     "wangjianjian (C)" <wangjianjian3@...wei.com>, tytso@....edu,
        adilger.kernel@...ger.ca
Cc:     linux-ext4@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH] ext4, doc: Fix incorrect h_reserved size

"wangjianjian (C)" <wangjianjian3@...wei.com> writes:

> According to document and code, ext4_xattr_header's size is 32 bytes, so
> h_reserved size should be 3.
>
> Signed-off-by: Wang Jianjian <wangjianjian3@...wei.com>
> ---
>   Documentation/filesystems/ext4/attributes.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/ext4/attributes.rst 
> b/Documentation/filesystems/ext4/attributes.rst
> index 54386a010a8d..871d2da7a0a9 100644
> --- a/Documentation/filesystems/ext4/attributes.rst
> +++ b/Documentation/filesystems/ext4/attributes.rst
> @@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
>        - Checksum of the extended attribute block.
>      * - 0x14
>        - \_\_u32
> -     - h\_reserved[2]
> +     - h\_reserved[3]
>        - Zero.
>

So this patch looks whitespace-damaged, please be sure that you can send
applyable patches to the list.

Beyond that, though, while you're in the neighborhood, please fix the
unnecessary underscore escaping (i.e. s/\_/_/).

Thanks,

jon