linux-ext4 - RE: [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <KL1PR0601MB400369725474F2A2DE647057BBF39@KL1PR0601MB4003.apcprd06.prod.outlook.com>
Date:   Mon, 18 Apr 2022 07:34:52 +0000
From:   常凤楠 <changfengnan@...o.com>
To:     Eric Biggers <ebiggers@...nel.org>
CC:     "jaegeuk@...nel.org" <jaegeuk@...nel.org>,
        "chao@...nel.org" <chao@...nel.org>,
        "tytso@....edu" <tytso@....edu>,
        "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "linux-f2fs-devel@...ts.sourceforge.net" 
        <linux-f2fs-devel@...ts.sourceforge.net>
Subject: RE: [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt

> -----Original Message-----
> From: Eric Biggers <ebiggers@...nel.org>
> Sent: Monday, April 18, 2022 3:22 PM
> To: 常凤楠 <changfengnan@...o.com>
> Cc: jaegeuk@...nel.org; chao@...nel.org; tytso@....edu;
> adilger.kernel@...ger.ca; axboe@...nel.dk; linux-block@...r.kernel.org;
> linux-ext4@...r.kernel.org; linux-f2fs-devel@...ts.sourceforge.net
> Subject: Re: [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt
> 
> On Mon, Apr 18, 2022 at 02:33:11PM +0800, Fengnan Chang via
> Linux-f2fs-devel wrote:
> > Notify when mount filesystem with -o inlinecrypt option, but the
> > device not support inlinecrypt.
> >
> > Signed-off-by: Fengnan Chang <changfengnan@...o.com>
> 
> You didn't include a cover letter in this patchset.  Can you explain what
> problem this patchset is meant to solve?

What I'm try to make is when devices not support inlinecrypt, do not show inlinecrypt in mount option. 
When I test fscrypt first, it make me confused. Not a real problem, just make this logical more reasonable.
Do you think this needs to be revised?

> 
> Note that there are multiple factors that affect whether inline encryption can
> be used with a particular file, such as whether the device supports the
> required encryption mode, data unit size, and data unit number size.  So
> your warning might not trigger even if inline encryption can't be used.  Also,
> your warning will never trigger if the kernel has
> CONFIG_BLK_INLINE_ENCRYPTION_FALLBACK=y.

I get it.

> 
> I recently sent out a patch that makes fs/crypto/ consistently log a message
> when starting to use an encryption implementation for the first time:
> https://lore.kernel.org/r/20220414053415.158986-1-ebiggers@kernel.org.
> It already did this for the crypto API, but not blk-crypto.  Being silent for
> blk-crypto was somewhat of an oversight.  These log messages make it clear
> which encryption implementations are in use.
> 
> Does that patch solve the problem you are trying to solve?

I think it's a different point.

Thanks.

> 
> - Eric