linux-ext4 - Re: [PATCH v3 3/7] ext4: Implement ci comparison using unicode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 May 2022 04:13:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>, tytso@....edu,
        adilger.kernel@...ger.ca, jaegeuk@...nel.org
Cc:     kbuild-all@...ts.01.org, linux-ext4@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net, ebiggers@...nel.org,
        Gabriel Krisman Bertazi <krisman@...labora.com>,
        kernel@...labora.com
Subject: Re: [PATCH v3 3/7] ext4: Implement ci comparison using unicode_name

Hi Gabriel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tytso-ext4/dev]
[also build test WARNING on jaegeuk-f2fs/dev-test linus/master v5.18-rc6 next-20220509]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Gabriel-Krisman-Bertazi/Clean-up-the-case-insenstive-lookup-path/20220430-022957
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: x86_64-rhel-8.3-func (https://download.01.org/0day-ci/archive/20220510/202205100425.howJyxrE-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/825d568247e8fc56f2f7e657c434936c7961cefc
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/Clean-up-the-case-insenstive-lookup-path/20220430-022957
        git checkout 825d568247e8fc56f2f7e657c434936c7961cefc
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/ext4/ fs/f2fs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   fs/ext4/namei.c: In function 'ext4_match':
   fs/ext4/namei.c:1431:13: warning: unused variable 'ret' [-Wunused-variable]
    1431 |         int ret;
         |             ^~~
>> fs/ext4/namei.c:1429:29: warning: unused variable 'u' [-Wunused-variable]
    1429 |         struct unicode_name u;
         |                             ^


vim +/u +1429 fs/ext4/namei.c

  1419	
  1420	/*
  1421	 * Test whether a directory entry matches the filename being searched for.
  1422	 *
  1423	 * Return: %true if the directory entry matches, otherwise %false.
  1424	 */
  1425	static bool ext4_match(struct inode *parent,
  1426				      const struct ext4_filename *fname,
  1427				      struct ext4_dir_entry_2 *de)
  1428	{
> 1429		struct unicode_name u;
  1430		struct fscrypt_name f;
  1431		int ret;
  1432	
  1433		if (!de->inode)
  1434			return false;
  1435	
  1436		f.usr_fname = fname->usr_fname;
  1437		f.disk_name = fname->disk_name;
  1438	#ifdef CONFIG_FS_ENCRYPTION
  1439		f.crypto_buf = fname->crypto_buf;
  1440	#endif
  1441	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp