lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 May 2022 14:59:57 -0700 From: Eric Biggers <ebiggers@...nel.org> To: Ritesh Harjani <ritesh.list@...il.com> Cc: linux-fscrypt@...r.kernel.org, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, Lukas Czerner <lczerner@...hat.com>, Theodore Ts'o <tytso@....edu>, Jaegeuk Kim <jaegeuk@...nel.org>, Jeff Layton <jlayton@...nel.org> Subject: Re: [PATCH v2 5/7] ext4: fix up test_dummy_encryption handling for new mount API On Fri, May 13, 2022 at 04:37:41PM +0530, Ritesh Harjani wrote: > > @@ -2623,10 +2609,11 @@ static int parse_apply_sb_mount_options(struct super_block *sb, > > if (s_ctx->spec & EXT4_SPEC_JOURNAL_IOPRIO) > > m_ctx->journal_ioprio = s_ctx->journal_ioprio; > > > > - ret = ext4_apply_options(fc, sb); > > + ext4_apply_options(fc, sb); > > + ret = 0; > > > > out_free: > > - kfree(s_ctx); > > + __ext4_fc_free(s_ctx); > > I think we can still call ext4_fc_free(fc) and we don't need __ext4_fc_free(). > Right? > Yes, you're right. I might have missed that fc->fs_private was being set above. I was also a little lazy here; the part below 'out_free:' should be a separate patch since it also fixes a memory leak of s_qf_names. I'll fix that up. - Eric
Powered by blists - more mailing lists