lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 May 2022 10:15:49 +0530 From: Ritesh Harjani <ritesh.list@...il.com> To: Eric Biggers <ebiggers@...nel.org> Cc: linux-ext4@...r.kernel.org, linux-fscrypt@...r.kernel.org, Theodore Ts'o <tytso@....edu>, Jan Kara <jack@...e.cz> Subject: Re: [PATCHv2 1/3] ext4: Move ext4 crypto code to its own file crypto.c On 22/05/14 08:33PM, Eric Biggers wrote: > On Sat, May 14, 2022 at 10:52:46PM +0530, Ritesh Harjani wrote: > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h > > index a743b1e3b89e..9100f0ba4a52 100644 > > --- a/fs/ext4/ext4.h > > +++ b/fs/ext4/ext4.h > > @@ -2731,6 +2731,9 @@ extern int ext4_fname_setup_ci_filename(struct inode *dir, > > struct ext4_filename *fname); > > #endif > > > > +/* ext4 encryption related stuff goes here crypto.c */ > > +extern const struct fscrypt_operations ext4_cryptops; > > + > > #ifdef CONFIG_FS_ENCRYPTION > > Shouldn't the declaration of ext4_cryptops go in the CONFIG_FS_ENCRYPTION block? Sure yes. I should move that within CONFIG_FS_ENCRYPTION block. > > Otherwise this patch looks good, thanks. > > Reviewed-by: Eric Biggers <ebiggers@...gle.com> Thanks for the review. -ritesh
Powered by blists - more mailing lists