lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 May 2022 14:23:10 +0530 From: Ojaswin Mujoo <ojaswin@...ux.ibm.com> To: fstests@...r.kernel.org, riteshh@...ux.ibm.com, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] common/rc: Modify _require_batched_discard to improve test coverage > > Oh I forgot to ask why we need to add a variable (ret), to record the return > value at here. Why can't use "$?" directly? e.g. > > grep -q "not supported" <($FSTRIM_PROG $1 2>&1) > if [ $? -eq 0 ] > > Others look good to me. > > Thanks, > Zorro That's right, I did it out of habbit. Anyways, I have eliminated the variable and sent in a new version here [1]. Let me know if it looks good. Thank you! Ojaswin [1] https://lore.kernel.org/all/20220516084505.97655-1-ojaswin@linux.ibm.com/ > > > + then > > + _notrun "FITRIM not supported on $1" > > + fi > > } > > > > _require_dumpe2fs() > > -- > > 2.27.0 > > >
Powered by blists - more mailing lists