linux-ext4 - Re: [PATCH v2] ext4/053: update the test_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YpUfVyGkNfQNZA7r@sol.localdomain>
Date:   Mon, 30 May 2022 12:47:35 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Theodore Ts'o <tytso@....edu>
Cc:     fstests@...r.kernel.org, linux-ext4@...r.kernel.org,
        Lukas Czerner <lczerner@...hat.com>
Subject: Re: [PATCH v2] ext4/053: update the test_dummy_encryption tests

On Mon, May 30, 2022 at 03:07:46PM -0400, Theodore Ts'o wrote:
> On Mon, May 30, 2022 at 10:30:44AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@...gle.com>
> > 
> > Kernel commit 5f41fdaea63d ("ext4: only allow test_dummy_encryption when
> > supported") tightened the requirements on when the test_dummy_encryption
> > mount option is accepted.  Update ext4/053 accordingly.
> > 
> > Move the test cases to later in the file to group them with the other
> > test cases that use do_mkfs to add custom mkfs options instead of using
> > the "default" filesystem that the test creates at the beginning.
> > 
> > Reviewed-by: Lukas Czerner <lczerner@...hat.com>
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> 
> I thought we were going to put in a kernel version check in so that
> this won't break on pre-5.19 kernels?  The thinking was that we
> wouldn't be backporting commit 5f41fdaea63d to LTS or distro kernels,
> so the version number check would be reliable in this instance.
> 
> Otherwise people who are testing enterprise kernels, LTS kernels,
> etc., will see this test fail.
> 
> 					- Ted

This was already discussed in the original thread.  IIUC, both Zorro and Lukas
prefer *not* having the kernel version check.

The whole test script is still gated on 5.12, so I'll only have to backport the
commit to 5.15 (unless the 5.12 version check gets removed).

- Eric