lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Jun 2022 18:33:23 +0200 From: David Sterba <dsterba@...e.cz> To: "Matthew Wilcox (Oracle)" <willy@...radead.org> Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, linux-block@...r.kernel.org, linux-aio@...ck.org, linux-btrfs@...r.kernel.org, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, cluster-devel@...hat.com, linux-mm@...ck.org, linux-xfs@...r.kernel.org, linux-nfs@...r.kernel.org, linux-ntfs-dev@...ts.sourceforge.net, ocfs2-devel@....oracle.com, linux-mtd@...ts.infradead.org, virtualization@...ts.linux-foundation.org, Christoph Hellwig <hch@....de> Subject: Re: [PATCH v2 12/19] btrfs: Convert btrfs_migratepage to migrate_folio On Wed, Jun 08, 2022 at 04:02:42PM +0100, Matthew Wilcox (Oracle) wrote: > Use filemap_migrate_folio() to do the bulk of the work, and then copy > the ordered flag across if needed. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org> > Reviewed-by: Christoph Hellwig <hch@....de> Acked-by: David Sterba <dsterba@...e.com> > +static int btrfs_migrate_folio(struct address_space *mapping, > + struct folio *dst, struct folio *src, > enum migrate_mode mode) > { > - int ret; > + int ret = filemap_migrate_folio(mapping, dst, src, mode); > > - ret = migrate_page_move_mapping(mapping, newpage, page, 0); > if (ret != MIGRATEPAGE_SUCCESS) > return ret; > > - if (page_has_private(page)) > - attach_page_private(newpage, detach_page_private(page)); If I'm reading it correctly, the private pointer does not need to be set like that anymore because it's done somewhere during the filemap_migrate_folio() call. > - > - if (PageOrdered(page)) { > - ClearPageOrdered(page); > - SetPageOrdered(newpage); > + if (folio_test_ordered(src)) { > + folio_clear_ordered(src); > + folio_set_ordered(dst); > }
Powered by blists - more mailing lists