lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Jun 2022 19:31:19 +0200 From: Jan Kara <jack@...e.cz> To: Christoph Hellwig <hch@....de> Cc: Matthew Wilcox <willy@...radead.org>, Jan Kara <jack@...e.com>, Dave Kleikamp <shaggy@...nel.org>, linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, jfs-discussion@...ts.sourceforge.net Subject: Re: [PATCH 4/5] fs: don't call ->writepage from __mpage_writepage On Wed 08-06-22 17:04:50, Christoph Hellwig wrote: > All callers of mpage_writepage use block_write_full_page as their > ->writepage implementation, so hard code that. > > Signed-off-by: Christoph Hellwig <hch@....de> Similarly here NTFS (fs/ntfs3/) seems to have some non-trivial stuff besides block_write_full_page()... Honza > --- > fs/mpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/mpage.c b/fs/mpage.c > index 31a97a0acf5f5..a354ef2b4b4eb 100644 > --- a/fs/mpage.c > +++ b/fs/mpage.c > @@ -624,7 +624,7 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc, > /* > * The caller has a ref on the inode, so *mapping is stable > */ > - ret = mapping->a_ops->writepage(page, wbc); > + ret = block_write_full_page(page, mpd->get_block, wbc); > mapping_set_error(mapping, ret); > out: > mpd->bio = bio; > -- > 2.30.2 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists