lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yqb21hTVUvob/sgc@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com> Date: Mon, 13 Jun 2022 14:05:34 +0530 From: Ojaswin Mujoo <ojaswin@...ux.ibm.com> To: fstests@...r.kernel.org Cc: zlang@...hat.com, riteshh@...ux.ibm.com, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3] common/rc: Modify _require_batched_discard to improve test coverage Greetings, Please let me know if there are any reviews/suggestions on this patch. Thank you! On Mon, May 16, 2022 at 02:15:05PM +0530, Ojaswin Mujoo wrote: > A recent ext4 patch discussed [1] that some devices (eg LVMs) can > have a discard granularity as big as 42MB which makes it larger > than the group size of ext4 FS with 1k BS. This causes the FITRIM > IOCTL to fail. > > This case was not correctly handled by this test since > "_require_batched_discard" incorrectly interpreted the FITRIM > failure as SCRATCH_DEV not supporting the IOCTL. This caused the test > to report "not run" instead of "failed" in case of large discard granularity. > > Fix "_require_batched_discard" to use a more accurate method > to determine if discard is supported. > > [1] commit 173b6e383d2 > ext4: avoid trim error on fs with small groups > > Signed-off-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com> > Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com> > --- > > Changes since v2 [1] > > * Eliminated redundant $ret variable > > [1] > https://lore.kernel.org/all/20220516063951.87838-1-ojaswin@linux.ibm.com/
Powered by blists - more mailing lists