lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 13 Jun 2022 14:05:34 +0530
From:   Ojaswin Mujoo <>
Subject: Re: [PATCH v3] common/rc: Modify _require_batched_discard to improve
 test coverage


Please let me know if there are any reviews/suggestions on this

Thank you!

On Mon, May 16, 2022 at 02:15:05PM +0530, Ojaswin Mujoo wrote:
> A recent ext4 patch discussed [1] that some devices (eg LVMs) can
> have a discard granularity as big as 42MB which makes it larger
> than the group size of ext4 FS with 1k BS.  This causes the FITRIM
> IOCTL to fail.
> This case was not correctly handled by this test since
> "_require_batched_discard" incorrectly interpreted the FITRIM
> failure as SCRATCH_DEV not supporting the IOCTL. This caused the test
> to report "not run" instead of "failed" in case of large discard granularity.
> Fix "_require_batched_discard" to use a more accurate method
> to determine if discard is supported.
> [1] commit 173b6e383d2
>     ext4: avoid trim error on fs with small groups
> Signed-off-by: Ojaswin Mujoo <>
> Reviewed-by: Ritesh Harjani <>
> ---
> Changes since v2 [1] 
> *  Eliminated redundant $ret variable
> [1]

Powered by blists - more mailing lists