linux-ext4 - Re: [PATCH 1/6] ntfs3: refactor ntfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220613104647.wjt27tqijdou3vm4@quack3.lan>
Date:   Mon, 13 Jun 2022 12:46:47 +0200
From:   Jan Kara <jack@...e.cz>
To:     Christoph Hellwig <hch@....de>
Cc:     Matthew Wilcox <willy@...radead.org>, Jan Kara <jack@...e.com>,
        Dave Kleikamp <shaggy@...nel.org>,
        Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
        linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, jfs-discussion@...ts.sourceforge.net,
        ntfs3@...ts.linux.dev
Subject: Re: [PATCH 1/6] ntfs3: refactor ntfs_writepages

On Mon 13-06-22 07:37:10, Christoph Hellwig wrote:
> Handle the resident case with an explicit generic_writepages call instead
> of using the obscure overload that makes mpage_writepages with a NULL
> get_block do the same thing.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Yeah, much more obvious :). Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ntfs3/inode.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index be4ebdd8048b0..28c09c25b823d 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -851,12 +851,10 @@ static int ntfs_writepage(struct page *page, struct writeback_control *wbc)
>  static int ntfs_writepages(struct address_space *mapping,
>  			   struct writeback_control *wbc)
>  {
> -	struct inode *inode = mapping->host;
> -	struct ntfs_inode *ni = ntfs_i(inode);
>  	/* Redirect call to 'ntfs_writepage' for resident files. */
> -	get_block_t *get_block = is_resident(ni) ? NULL : &ntfs_get_block;
> -
> -	return mpage_writepages(mapping, wbc, get_block);
> +	if (is_resident(ntfs_i(mapping->host)))
> +		return generic_writepages(mapping, wbc);
> +	return mpage_writepages(mapping, wbc, ntfs_get_block);
>  }
>  
>  static int ntfs_get_block_write_begin(struct inode *inode, sector_t vbn,
> -- 
> 2.30.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR