lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jun 2022 14:46:33 +0200 From: Jan Kara <jack@...e.cz> To: Baokun Li <libaokun1@...wei.com> Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, ritesh.list@...il.com, lczerner@...hat.com, enwlinux@...il.com, linux-kernel@...r.kernel.org, yi.zhang@...wei.com, yebin10@...wei.com, yukuai3@...wei.com Subject: Re: [PATCH v2 1/4] ext4: add EXT4_INODE_HAVE_XATTR_SPACE macro in xattr.h On Wed 15-06-22 12:06:27, Baokun Li wrote: > When adding an xattr to an inode, we must ensure that the inode_size is > not less than EXT4_GOOD_OLD_INODE_SIZE + extra_isize + pad. Otherwise, > the end position may be greater than the start position, resulting in UAF. > > Signed-off-by: Baokun Li <libaokun1@...wei.com> ... > +/* > + * If we want to add an xattr to the inode, we should make sure that > + * i_extra_isize is not 0 and that the inode size is not less than > + * EXT4_GOOD_OLD_INODE_SIZE + extra_isize + pad. > + * EXT4_GOOD_OLD_INODE_SIZE extra_isize header entry pad data > + * |--------------------------|------------|------|---------|---|-------| > + */ > +#define EXT4_INODE_HAVE_XATTR_SPACE(inode) \ Gramatically correct would be EXT4_INODE_**HAS**_XATTR_SPACE and I'd be for using that. Otherwise the whole series looks good so feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists