lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jun 2022 12:08:55 +0200 From: Jan Kara <jack@...e.cz> To: Baokun Li <libaokun1@...wei.com> Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, ritesh.list@...il.com, lczerner@...hat.com, enwlinux@...il.com, linux-kernel@...r.kernel.org, yi.zhang@...wei.com, yebin10@...wei.com, yukuai3@...wei.com Subject: Re: [PATCH v3 3/4] ext4: correct max_inline_xattr_value_size computing On Thu 16-06-22 10:13:57, Baokun Li wrote: > If the ext4 inode does not have xattr space, 0 is returned in the > get_max_inline_xattr_value_size function. Otherwise, the function returns > a negative value when the inode does not contain EXT4_STATE_XATTR. > > Signed-off-by: Baokun Li <libaokun1@...wei.com> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/inline.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c > index cff52ff6549d..da5de43623dd 100644 > --- a/fs/ext4/inline.c > +++ b/fs/ext4/inline.c > @@ -35,6 +35,9 @@ static int get_max_inline_xattr_value_size(struct inode *inode, > struct ext4_inode *raw_inode; > int free, min_offs; > > + if (!EXT4_INODE_HAS_XATTR_SPACE(inode)) > + return 0; > + > min_offs = EXT4_SB(inode->i_sb)->s_inode_size - > EXT4_GOOD_OLD_INODE_SIZE - > EXT4_I(inode)->i_extra_isize - > -- > 2.31.1 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists