lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jun 2022 14:40:19 +0530 From: Ritesh Harjani <ritesh.list@...il.com> To: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org Cc: Jan Kara <jack@...e.com>, Alexander Viro <viro@...iv.linux.org.uk>, Christoph Hellwig <hch@....de>, kernel test robot <lkp@...el.com>, linux-ntfs-dev@...ts.sourceforge.net Subject: Re: [PATCHv2 2/4] fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read + linux-ntfs-dev@...ts.sourceforge.net (sorry about not cc'ing this in the first place) On 22/06/20 02:34PM, Ritesh Harjani wrote: > submit_bh always returns 0. This patch drops the useless return value of > submit_bh from ntfs_submit_bh_for_read(). Once all of submit_bh callers are > cleaned up, we can make it's return type as void. > > Reported-by: kernel test robot <lkp@...el.com> > Signed-off-by: Ritesh Harjani <ritesh.list@...il.com> > --- > fs/ntfs/file.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c > index a8abe2296514..2389bfa654a2 100644 > --- a/fs/ntfs/file.c > +++ b/fs/ntfs/file.c > @@ -532,12 +532,12 @@ static inline int __ntfs_grab_cache_pages(struct address_space *mapping, > goto out; > } > > -static inline int ntfs_submit_bh_for_read(struct buffer_head *bh) > +static inline void ntfs_submit_bh_for_read(struct buffer_head *bh) > { > lock_buffer(bh); > get_bh(bh); > bh->b_end_io = end_buffer_read_sync; > - return submit_bh(REQ_OP_READ, 0, bh); > + submit_bh(REQ_OP_READ, 0, bh); > } > > /** > -- > 2.35.3 >
Powered by blists - more mailing lists