lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jun 2022 11:28:39 +0530 From: Ritesh Harjani <ritesh.list@...il.com> To: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org Cc: Jan Kara <jack@...e.com>, Alexander Viro <viro@...iv.linux.org.uk>, Ritesh Harjani <ritesh.list@...il.com> Subject: [RFC 0/3] submit_bh: Drop unnecessary return values and API users submit_bh/submit_bh_wbc are non-blocking functions which just submits the bio and returns. The caller of submit_bh/submit_bh_wbc needs to wait on buffer till I/O completion and then check buffer head's b_state field to know if there was any I/O error. Hence there is no need for these functions to have any return type. Even now they always returns 0. Hence drop the return value and make their return type as void to avoid any confusion. Ritesh Harjani (3): jbd2: Drop useless return value of submit_bh fs/buffer: Drop useless return value of submit_bh fs/buffer: Make submit_bh & submit_bh_wbc return type as void fs/buffer.c | 19 ++++++++----------- fs/jbd2/commit.c | 11 +++++------ fs/jbd2/journal.c | 6 ++---- include/linux/buffer_head.h | 2 +- 4 files changed, 16 insertions(+), 22 deletions(-) -- 2.35.3
Powered by blists - more mailing lists