linux-ext4 - Re: [PATCHv2 2/4] fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220621063432.GA826@lst.de>
Date:   Tue, 21 Jun 2022 08:34:32 +0200
From:   Christoph Hellwig <hch@....de>
To:     Ritesh Harjani <ritesh.list@...il.com>
Cc:     linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Jan Kara <jack@...e.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@....de>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCHv2 2/4] fs/ntfs: Drop useless return value of submit_bh
 from ntfs_submit_bh_for_read

On Mon, Jun 20, 2022 at 02:34:35PM +0530, Ritesh Harjani wrote:
> submit_bh always returns 0. This patch drops the useless return value of
> submit_bh from ntfs_submit_bh_for_read(). Once all of submit_bh callers are
> cleaned up, we can make it's return type as void.

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>

and so sad that a newly merged file systems still does all this buffer head
crap :(