linux-ext4 - Re: [RFC 1/3] jbd2: Drop useless return value of submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220704090144.hdj3fpaaqyj35yt3@riteshh-domain>
Date:   Mon, 4 Jul 2022 14:31:44 +0530
From:   Ritesh Harjani <ritesh.list@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Jan Kara <jack@...e.com>,
        Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [RFC 1/3] jbd2: Drop useless return value of submit_bh

On 22/06/21 02:39AM, Matthew Wilcox wrote:
> On Mon, Jun 20, 2022 at 11:28:40AM +0530, Ritesh Harjani wrote:
> > @@ -1636,14 +1636,12 @@ static int jbd2_write_superblock(journal_t *journal, int write_flags)
> >  		sb->s_checksum = jbd2_superblock_csum(journal, sb);
> >  	get_bh(bh);
> >  	bh->b_end_io = end_buffer_write_sync;
> > -	ret = submit_bh(REQ_OP_WRITE, write_flags, bh);
> > +	submit_bh(REQ_OP_WRITE, write_flags, bh);
> >  	wait_on_buffer(bh);
> >  	if (buffer_write_io_error(bh)) {
> >  		clear_buffer_write_io_error(bh);
> >  		set_buffer_uptodate(bh);
> >  		ret = -EIO;
> > -	}
> > -	if (ret) {
> >  		printk(KERN_ERR "JBD2: Error %d detected when updating "
> >  		       "journal superblock for %s.\n", ret,
> >  		       journal->j_devname);
>
> Maybe rephrase the error message?  And join it together to match the
> current preferred style.
>
> 		printk(KERN_ERR "JBD2: I/O error when updating journal superblock for %s.\n",
> 				journal->j_devname);

Sure, I will update the printk message like above and send out a v3
(since I haven't receieved any other comments so I think v3 should be good to be
picked up now)

-ritesh