linux-ext4 - Re: [PATCH 2/2] ext4: update the s_overhead_clusters in the backup sb's when resizing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jul 2022 10:35:59 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 2/2] ext4: update the s_overhead_clusters in the backup
 sb's when resizing

On Mon, Jul 04, 2022 at 02:50:47PM -0600, Andreas Dilger wrote:
> > -void ext4_resize_end(struct super_block *sb)
> > +int ext4_resize_end(struct super_block *sb, bool update_backups)
> > {
> > 	clear_bit_unlock(EXT4_FLAGS_RESIZING, &EXT4_SB(sb)->s_ext4_flags);
> > 	smp_mb__after_atomic();
> > +	if (update_backups)
> > +		return ext4_update_overhead(sb, true);
> > +	else
> > +		return 0;
> 
> (style) no need for "else" after return.

Good point, I'll make that adjustment.

				- Ted