lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jul 2022 14:25:38 +0200 From: Christoph Böhmwalder <christoph.boehmwalder@...bit.com> To: Christoph Hellwig <hch@....de> Cc: Jens Axboe <axboe@...nel.dk>, "Md. Haris Iqbal" <haris.iqbal@...os.com>, Jack Wang <jinpu.wang@...os.com>, Song Liu <song@...nel.org>, Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>, Jan Kara <jack@...e.com>, Mark Fasheh <mark@...heh.com>, Joel Becker <jlbec@...lplan.org>, Joseph Qi <joseph.qi@...ux.alibaba.com>, linux-block@...r.kernel.org, drbd-dev@...ts.linbit.com, linux-raid@...r.kernel.org, linux-ext4@...r.kernel.org, ocfs2-devel@....oracle.com Subject: Re: [PATCH 3/9] drbd: stop using bdevname in drbd_report_io_error Am 13.07.22 um 07:53 schrieb Christoph Hellwig: > Just use the %pg format specifier instead. > > Signed-off-by: Christoph Hellwig <hch@....de> > --- > drivers/block/drbd/drbd_req.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c > index e64bcfba30ef3..6d8dd14458c69 100644 > --- a/drivers/block/drbd/drbd_req.c > +++ b/drivers/block/drbd/drbd_req.c > @@ -523,16 +523,14 @@ static void mod_rq_state(struct drbd_request *req, struct bio_and_error *m, > > static void drbd_report_io_error(struct drbd_device *device, struct drbd_request *req) > { > - char b[BDEVNAME_SIZE]; > - > if (!__ratelimit(&drbd_ratelimit_state)) > return; > > - drbd_warn(device, "local %s IO error sector %llu+%u on %s\n", > + drbd_warn(device, "local %s IO error sector %llu+%u on %pg\n", > (req->rq_state & RQ_WRITE) ? "WRITE" : "READ", > (unsigned long long)req->i.sector, > req->i.size >> 9, > - bdevname(device->ldev->backing_bdev, b)); > + device->ldev->backing_bdev); > } > > /* Helper for HANDED_OVER_TO_NETWORK. For the drbd part: Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@...bit.com> Thanks. -- Christoph Böhmwalder LINBIT | Keeping the Digital World Running DRBD HA — Disaster Recovery — Software defined Storage
Powered by blists - more mailing lists