linux-ext4 - Re: [PATCH v4] ext4: truncate during setxattr leads to kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202207150257.B4gnbAMM-lkp@intel.com>
Date:   Fri, 15 Jul 2022 02:45:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     Artem Blagodarenko <artem.blagodarenko@...il.com>,
        linux-ext4@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        adilger.kernel@...ger.ca, andrew.perepechko@....com,
        Artem Blagodarenko <artem.blagodarenko@...il.com>
Subject: Re: [PATCH v4] ext4: truncate during setxattr leads to kernel panic

Hi Artem,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tytso-ext4/dev]
[also build test WARNING on linus/master v5.19-rc6 next-20220714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Artem-Blagodarenko/ext4-truncate-during-setxattr-leads-to-kernel-panic/20220711-232350
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: hexagon-randconfig-r045-20220714 (https://download.01.org/0day-ci/archive/20220715/202207150257.B4gnbAMM-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e61b9c556267086ef9b743a0b57df302eef831b)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/600aeea1cc6d36f380862bb88e50b670e0a57e4f
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Artem-Blagodarenko/ext4-truncate-during-setxattr-leads-to-kernel-panic/20220711-232350
        git checkout 600aeea1cc6d36f380862bb88e50b670e0a57e4f
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/btrfs/ fs/ext4/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/ext4/xattr.c:1563:15: warning: no previous prototype for function 'delayed_iput' [-Wmissing-prototypes]
   noinline void delayed_iput(struct inode *inode, struct delayed_iput_work *work)
                 ^
   fs/ext4/xattr.c:1563:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
   noinline void delayed_iput(struct inode *inode, struct delayed_iput_work *work)
            ^
            static 
   1 warning generated.


vim +/delayed_iput +1563 fs/ext4/xattr.c

  1562	
> 1563	noinline void delayed_iput(struct inode *inode, struct delayed_iput_work *work)
  1564	{
  1565		if (!inode) {
  1566			kfree(work);
  1567			return;
  1568		}
  1569	
  1570		if (!work) {
  1571			iput(inode);
  1572		} else {
  1573			INIT_WORK(&work->work, delayed_iput_fn);
  1574			work->inode = inode;
  1575			queue_work(EXT4_SB(inode->i_sb)->s_misc_wq, &work->work);
  1576		}
  1577	}
  1578	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp