linux-ext4 - Re: [PATCH 4.19] ext4: fix race condition between ext4_ioctl_setflags and ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yta6THyDwHulhfi5@mit.edu>
Date:   Tue, 19 Jul 2022 10:06:04 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Baokun Li <libaokun1@...wei.com>, stable@...r.kernel.org,
        linux-ext4@...r.kernel.org, adilger.kernel@...ger.ca, jack@...e.cz,
        ritesh.list@...il.com, lczerner@...hat.com, enwlinux@...il.com,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
        yebin10@...wei.com, yukuai3@...wei.com,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH 4.19] ext4: fix race condition between
 ext4_ioctl_setflags and ext4_fiemap

On Tue, Jul 19, 2022 at 01:26:57PM +0200, Greg KH wrote:
> On Sat, Jul 16, 2022 at 10:33:30AM +0800, Baokun Li wrote:
> > This problem persists until the patch d3b6f23f7167("ext4: move ext4_fiemap
> > to use iomap framework") is incorporated in v5.7-rc1.
> 
> Then why not ask for that change to be added instead?

Switching over to use the iomap framework is a quite invasive change,
which is fraught with danager and potential performance regressions.
So it's really not something that would be considered safe for an LTS
kernel.

As an upstream developer I'd ask why are people trying to use a kernel
as old as 4.19, but RHEL has done more insane things than that.  Also,
I know what the answer is, and it's just too depressing for a nice
summer day like this.  :-)

       	  	    	     	       - Ted