lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Jul 2022 21:22:06 -0500 From: "Sierra Guiza, Alejandro (Alex)" <alex.sierra@....com> To: Andrew Morton <akpm@...ux-foundation.org>, David Hildenbrand <david@...hat.com> Cc: jgg@...dia.com, Felix.Kuehling@....com, linux-mm@...ck.org, rcampbell@...dia.com, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, hch@....de, jglisse@...hat.com, apopple@...dia.com, willy@...radead.org Subject: Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing On 7/18/2022 3:32 PM, Andrew Morton wrote: > On Mon, 18 Jul 2022 12:56:29 +0200 David Hildenbrand <david@...hat.com> wrote: > >>> /* >>> * Try to move out any movable page before pinning the range. >>> */ >>> @@ -1919,7 +1948,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, >>> folio_nr_pages(folio)); >>> } >>> >>> - if (!list_empty(&movable_page_list) || isolation_error_count) >>> + if (!list_empty(&movable_page_list) || isolation_error_count >>> + || coherent_pages) >> The common style is to >> >> a) add the || to the end of the previous line >> b) indent such the we have a nice-to-read alignment >> >> if (!list_empty(&movable_page_list) || isolation_error_count || >> coherent_pages) >> > I missed that. This series is now in mm-stable so any fix will need to > be a standalone followup patch, please. Hi Andrew, Just wanted to make sure nothing is missing from our side to merge this patch series. Regards, Alex Sierra > >> Apart from that lgtm. >> >> Reviewed-by: David Hildenbrand <david@...hat.com> > And your reviewed-by's will be lost. Stupid git.
Powered by blists - more mailing lists