lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YvJ3JPFQfzbhph89@magnolia> Date: Tue, 9 Aug 2022 08:03:00 -0700 From: "Darrick J. Wong" <djwong@...nel.org> To: Bagas Sanjaya <bagasdotme@...il.com> Cc: linux-doc@...r.kernel.org, stable@...nel.org, Andreas Dilger <adilger.kernel@...ger.ca>, Jonathan Corbet <corbet@....net>, Wang Jianjian <wangjianjian3@...wei.com>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, Theodore Ts'o <tytso@....edu> Subject: Re: [PATCH 5.19] Documentation: ext4: fix cell spacing of table heading on blockmap table On Tue, Aug 09, 2022 at 03:08:28PM +0700, Bagas Sanjaya wrote: > commit 442ec1e5bb7c46c72c41898e13a5744c84cadf51 upstream. > > Commit 3103084afcf234 ("ext4, doc: remove unnecessary escaping") removes > redundant underscore escaping, however the cell spacing in heading row of > blockmap table became not aligned anymore, hence triggers malformed table > warning: > > Documentation/filesystems/ext4/blockmap.rst:3: WARNING: Malformed table. > > +---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ > | i.i_block Offset | Where It Points | > <snipped>... > > The warning caused the table not being loaded. > > Realign the heading row cell by adding missing space at the first cell > to fix the warning. > > Fixes: 3103084afcf234 ("ext4, doc: remove unnecessary escaping") > Cc: stable@...nel.org > Cc: Andreas Dilger <adilger.kernel@...ger.ca> > Cc: Jonathan Corbet <corbet@....net> > Cc: Wang Jianjian <wangjianjian3@...wei.com> > Cc: linux-ext4@...r.kernel.org > Cc: linux-kernel@...r.kernel.org > Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com> > Link: https://lore.kernel.org/r/20220619072938.7334-1-bagasdotme@gmail.com > Signed-off-by: Theodore Ts'o <tytso@....edu> > Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com> > --- > > Seems like this patch is merged to Linus's tree as merge window > material for 6.0, but it should have been -rc fix material for 5.19 > cycle. Now that the version have been stabilized (and now on 6.0 merge > window), it should be logical to submit this backport for 5.19 tree. > > Documentation/filesystems/ext4/blockmap.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/filesystems/ext4/blockmap.rst b/Documentation/filesystems/ext4/blockmap.rst > index 2bd990402a5c49..cc596541ce7921 100644 > --- a/Documentation/filesystems/ext4/blockmap.rst > +++ b/Documentation/filesystems/ext4/blockmap.rst > @@ -1,7 +1,7 @@ > .. SPDX-License-Identifier: GPL-2.0 > > +---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ > -| i.i_block Offset | Where It Points | > +| i.i_block Offset | Where It Points | AHA, that's why I kept getting screenfuls of sphinx complaints when I was building the XFS documentation. Thanks for fixing this... Reviewed-by: Darrick J. Wong <djwong@...nel.org> --D > +=====================+==============================================================================================================================================================================================================================+ > | 0 to 11 | Direct map to file blocks 0 to 11. | > +---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ > -- > An old man doll... just what I always wanted! - Clara >
Powered by blists - more mailing lists