lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 10 Aug 2022 16:14:48 +0900
From:   Sergey Senozhatsky <>
To:     Jiri Slaby <>
Cc:,,,,,, Minchan Kim <>,
        Nitin Gupta <>,
        Sergey Senozhatsky <>,
        Alexey Romanov <>,
        Dmitry Rokosov <>,
        Lukas Czerner <>,
        Ext4 Developers List <>
Subject: Re: [PATCH] Revert "zram: remove double compression logic"

On (22/08/10 09:06), Jiri Slaby wrote:
> This reverts commit e7be8d1dd983156bbdd22c0319b71119a8fbb697 as it
> causes zram failures. It does not revert cleanly, PTR_ERR handling was
> introduced in the meantime. This is handled by appropriate IS_ERR.
> When under memory pressure, zs_malloc() can fail. Before the above
> commit, the allocation was retried with direct reclaim enabled
> (GFP_NOIO). After the commit, it is not -- only __GFP_KSWAPD_RECLAIM is
> tried.
> So when the failure occurs under memory pressure, the overlaying
> filesystem such as ext2 (mounted by ext4 module in this case) can emit
> failures, making the (file)system unusable:
>   EXT4-fs warning (device zram0): ext4_end_bio:343: I/O error 10 writing to inode 16386 starting block 159744)
>   Buffer I/O error on device zram0, logical block 159744
> With direct reclaim, memory is really reclaimed and allocation succeeds,
> eventually. In the worst case, the oom killer is invoked, which is
> proper outcome if user sets up zram too large (in comparison to
> available RAM).
> This very diff doesn't apply to 5.19 (stable) cleanly (see PTR_ERR note
> above). Use revert of e7be8d1dd983 directly.
> Link:
> Fixes: e7be8d1dd983 ("zram: remove double compression logic")
> Cc: # 5.19
> Cc: Minchan Kim <>
> Cc: Nitin Gupta <>
> Cc: Sergey Senozhatsky <>
> Cc: Alexey Romanov <>
> Cc: Dmitry Rokosov <>
> Cc: Lukas Czerner <>
> Cc: Ext4 Developers List <>
> Signed-off-by: Jiri Slaby <>

Reviewed-by: Sergey Senozhatsky <>

Powered by blists - more mailing lists