linux-ext4 - Re: [PATCH v3 1/3] ext4: don't increase iversion counter for ea

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220812130408.wb44zntp3jx7zpve@wittgenstein>
Date:   Fri, 12 Aug 2022 15:04:08 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     linux-ext4@...r.kernel.org, tytso@....edu, jlayton@...nel.org,
        jack@...e.cz, linux-fsdevel@...r.kernel.org, ebiggers@...nel.org,
        david@...morbit.com
Subject: Re: [PATCH v3 1/3] ext4: don't increase iversion counter for
 ea_inodes

On Fri, Aug 12, 2022 at 02:37:25PM +0200, Lukas Czerner wrote:
> ea_inodes are using i_version for storing part of the reference count so
> we really need to leave it alone.
> 
> The problem can be reproduced by xfstest ext4/026 when iversion is
> enabled. Fix it by not calling inode_inc_iversion() for EXT4_EA_INODE_FL
> inodes in ext4_mark_iloc_dirty().
> 
> Signed-off-by: Lukas Czerner <lczerner@...hat.com>
> Reviewed-by: Jan Kara <jack@...e.cz>
> Reviewed-by: Jeff Layton <jlayton@...nel.org>
> ---

Reviewed-by: Christian Brauner (Microsoft) <brauner@...nel.org>